Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure most cases of IllegalArgumentException for measures and caregaps are converted to FHIR InvalidRequestException #599

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lukedegruchy
Copy link
Contributor

@lukedegruchy lukedegruchy commented Nov 26, 2024

  • Convert all most cases of IllegalArgumentException for measures and caregaps are converted to FHIR InvalidRequestException where they make sense to ensure end users see 400 status codes in cases of user error
  • Adjust tests

Closes #596

…ps are converted to InvalidRequestException with additional context.
@lukedegruchy lukedegruchy changed the title Ensure most cases of IllegalArgumentException for measures and carega… Ensure most cases of IllegalArgumentException for measures and caregaps are converted to InvalidRequestException Nov 26, 2024
…argumentexception-to-invalidrequestexception
Copy link

github-actions bot commented Nov 26, 2024

Formatting check succeeded!

@lukedegruchy lukedegruchy marked this pull request as ready for review November 26, 2024 21:48
Copy link

sonarcloud bot commented Nov 26, 2024

@lukedegruchy lukedegruchy changed the title Ensure most cases of IllegalArgumentException for measures and caregaps are converted to InvalidRequestException Ensure most cases of IllegalArgumentException for measures and caregaps are converted to FHIR InvalidRequestException Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 61.17647% with 33 lines in your changes missing coverage. Please review.

Project coverage is 73.79%. Comparing base (83da84e) to head (81911c0).

Files with missing lines Patch % Lines
...cqf/fhir/cr/measure/r4/R4MeasureReportBuilder.java 28.57% 10 Missing ⚠️
...s/cqf/fhir/cr/measure/common/MeasureEvaluator.java 22.22% 7 Missing ⚠️
...hir/cr/measure/r4/utils/R4MeasureServiceUtils.java 25.00% 3 Missing ⚠️
.../fhir/cr/measure/common/BaseMeasureEvaluation.java 0.00% 2 Missing ⚠️
...ir/cr/measure/dstu3/Dstu3MeasureReportBuilder.java 33.33% 2 Missing ⚠️
...ds/cqf/fhir/cr/measure/r4/R4MeasureDefBuilder.java 88.88% 2 Missing ⚠️
.../cqf/fhir/cr/measure/r4/R4MeasureReportScorer.java 75.00% 2 Missing ⚠️
.../fhir/cr/measure/dstu3/Dstu3MeasureDefBuilder.java 75.00% 1 Missing ⚠️
.../fhir/cr/measure/dstu3/Dstu3MeasureEvaluation.java 0.00% 1 Missing ⚠️
...f/fhir/cr/measure/dstu3/Dstu3MeasureProcessor.java 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #599      +/-   ##
============================================
- Coverage     73.81%   73.79%   -0.02%     
  Complexity       19       19              
============================================
  Files           361      361              
  Lines         18974    18996      +22     
  Branches       2532     2532              
============================================
+ Hits          14006    14019      +13     
- Misses         3611     3620       +9     
  Partials       1357     1357              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant