Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to naiveExpand for existence of compose codes #557

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

barhodes
Copy link
Contributor

@barhodes barhodes commented Oct 10, 2024

The naiveExpand method on ValueSetAdapter will now only set the expansion if we have a compose with codes.

Copy link

github-actions bot commented Oct 10, 2024

Formatting check succeeded!

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.06%. Comparing base (f236c13) to head (850bbcf).

Files with missing lines Patch % Lines
...qf/fhir/utility/adapter/dstu3/ValueSetAdapter.java 91.66% 0 Missing and 1 partial ⚠️
...s/cqf/fhir/utility/adapter/r4/ValueSetAdapter.java 91.66% 0 Missing and 1 partial ⚠️
...s/cqf/fhir/utility/adapter/r5/ValueSetAdapter.java 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #557      +/-   ##
============================================
- Coverage     73.07%   73.06%   -0.01%     
  Complexity       19       19              
============================================
  Files           365      365              
  Lines         19370    19376       +6     
  Branches       2961     2964       +3     
============================================
+ Hits          14155    14158       +3     
  Misses         3787     3787              
- Partials       1428     1431       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@barhodes barhodes marked this pull request as ready for review October 10, 2024 23:22
Copy link

sonarcloud bot commented Oct 11, 2024

@barhodes barhodes marked this pull request as draft October 11, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant