Rename to enum variables to lower-case

Those would avoid weird defines from messing with the code.
cps-org · Oct 25, 2024 · 2844d73 · 2844d73
1 parent 4fffd18
commit 2844d73
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/cps/pc_compat/pc_base.hpp b/src/cps/pc_compat/pc_base.hpp
@@ -19,7 +19,7 @@ namespace cps::pc_compat {
     // PackageRequirement is the type of a non-terminal. bison needs
     // to do a sizeof on this type and cannot do so with a forward
     // declaration.
-    enum class VersionOperation { LT, LE, NE, EQ, GT, GE };
+    enum class VersionOperation { lt, le, ne, eq, gt, ge };
     struct PackageRequirement {
         std::string package;
         std::optional<VersionOperation> operation;

diff --git a/src/cps/pc_compat/pc_loader.cpp b/src/cps/pc_compat/pc_loader.cpp
@@ -28,22 +28,22 @@ namespace cps::pc_compat {
             return ost;
         }
         switch (*version_operation) {
-        case VersionOperation::EQ:
+        case VersionOperation::eq:
             ost << "=";
             break;
-        case VersionOperation::NE:
+        case VersionOperation::ne:
             ost << "!=";
             break;
-        case VersionOperation::LT:
+        case VersionOperation::lt:
             ost << "<";
             break;
-        case VersionOperation::LE:
+        case VersionOperation::le:
             ost << "<=";
             break;
-        case VersionOperation::GT:
+        case VersionOperation::gt:
             ost << ">";
             break;
-        case VersionOperation::GE:
+        case VersionOperation::ge:
             ost << ">=";
             break;
         }

diff --git a/tests/pc_parser.cpp b/tests/pc_parser.cpp
@@ -81,7 +81,7 @@ namespace cps::utils::test {
             assert_string_value(pc_loader.properties["Cflags"], "-I/home/kaniini/pkg/include/libfoo");
             assert_package_requirements(
                 pc_loader.properties["Requires"],
-                {PackageRequirement{.package = "libbar", .operation = VersionOperation::GT, .version = "2.0.0"}});
+                {PackageRequirement{.package = "libbar", .operation = VersionOperation::gt, .version = "2.0.0"}});
         }
     } // namespace
 } // namespace cps::utils::test