Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New error type should be a PrepareError variant, not a URI #8

Open
divergentdave opened this issue Jul 6, 2023 · 4 comments
Open

Comments

@divergentdave
Copy link
Contributor

The way that section 2 is written suggests that it defines a new error type URI, urn:ietf:params:ppm:dap:error:unauthenticatedReport. However, the error is only ever produced during aggregation job processing, within the scope of a single report. Thus, what is really needed is a new PrepareError variant. DAP does not yet define a registry for extensibility of this enum, see ietf-wg-ppm/draft-ietf-ppm-dap#487.

@cpriebe
Copy link
Owner

cpriebe commented Jul 7, 2023

Thanks! That makes sense to me. I was following the wording in https://datatracker.ietf.org/doc/draft-wang-ppm-dap-taskprov for which we might need the same?

Will add a TODO to the doc for now.

@cpriebe
Copy link
Owner

cpriebe commented Jul 7, 2023

Note added but will leave this open to track the actual resolution.

@divergentdave
Copy link
Contributor Author

I think taskprov is using error type URIs is alright, since its error can arise during report uploading. Only errors during report share preparation have to be represented using this more limited TLS-style enum.

@cpriebe
Copy link
Owner

cpriebe commented Jul 7, 2023

Ah, right. That makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants