Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default_port() takes a scheme but not a protocol() #135

Closed
AlexandreBossard opened this issue Jun 30, 2020 · 2 comments
Closed

default_port() takes a scheme but not a protocol() #135

AlexandreBossard opened this issue Jun 30, 2020 · 2 comments
Assignees
@glynos
Milestone
v2.0

Comments

@AlexandreBossard
Copy link 

auto const myurl = url("https://exampe.com");
url::default_port(myurl.protocol()).has_value(); // false

So, protocol() returns https: but default_port() needs a scheme (no ':'). Plus, there is no url::scheme() provided. Is this some overlooking ? Having to strip the ':' every time is annoying.
@glynos glynos mentioned this issue Jun 30, 2020
Merged
@glynos glynos self-assigned this Jun 30, 2020
@glynos
Copy link
Member

glynos commented Jun 30, 2020

That's a simple fix, I'd appreciate a short review of #136 to make sure I captured what you asked for.

@glynos glynos added this to the v2.0 milestone Jun 30, 2020
@glynos
Copy link
Member

glynos commented Jul 1, 2020

Fixed in #136

@glynos glynos closed this as completed Jul 1, 2020
GerHobbelt pushed a commit to GerHobbelt/url that referenced this issue Mar 18, 2024
@alandefreitas @vinniefalco
document BOOST_URL_NO_LIB
9927d80 
fix cpp-netlib#88, close cpp-netlib#135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glynos glynos

Labels
None yet
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
2 participants
@glynos @AlexandreBossard