Skip to content

Commit

Permalink
Introduction of a short field description to fields and fieldsets (el…
Browse files Browse the repository at this point in the history
…astic#330)

Additional things were fixed, while playing in these descriptions:

- Some definitions were adjusted in terms of wording and in terms of separating paragraphs (double \n)
- `cloud.provider` examples fixed to mention the actual provider, not a service like "ec2"
- Add pointer in `http` field description to `url`
- Lowercased the `log.level` examples. The field doesn't technically have the requirement, but at least we can start guiding in that direction for the future.
  • Loading branch information
webmat authored Feb 22, 2019
1 parent f2a3f1c commit 34b391c
Show file tree
Hide file tree
Showing 55 changed files with 567 additions and 267 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,13 @@ All notable changes to this project will be documented in this file based on the
* Field set name "group" was being used as a leaf field at `user.group`, instead
of being a nesting of the field set. This goes against a driving principle of ECS,
and has been corrected. #308
* Replaced incorrect examples in `cloud.provider`. #330

### Added

* Added pointer in description of `http` field set to `url` field set. #330
* Added an optional short field description. #330

### Improvements
* Clarified the definition of the host fields #325
* Specify the `object_type` for field `labels`. #331
Expand Down
110 changes: 74 additions & 36 deletions README.md

Large diffs are not rendered by default.

9 changes: 5 additions & 4 deletions code/go/ecs/agent.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 8 additions & 7 deletions code/go/ecs/base.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions code/go/ecs/client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion code/go/ecs/cloud.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions code/go/ecs/container.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion code/go/ecs/ecs.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions code/go/ecs/error.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 13 additions & 12 deletions code/go/ecs/event.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions code/go/ecs/file.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions code/go/ecs/host.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions code/go/ecs/http.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions code/go/ecs/log.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 8 additions & 7 deletions code/go/ecs/network.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions code/go/ecs/observer.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions code/go/ecs/organization.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions code/go/ecs/process.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 8 additions & 7 deletions code/go/ecs/related.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions code/go/ecs/server.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions code/go/ecs/service.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 34b391c

Please sign in to comment.