Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG Poll 2: P2051R0 C++ Standard Library Issues to be moved in Prague #3748

Merged
merged 44 commits into from
Feb 27, 2020
Merged

LWG Poll 2: P2051R0 C++ Standard Library Issues to be moved in Prague #3748

merged 44 commits into from
Feb 27, 2020

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Feb 19, 2020 •
edited by jensmaurer
Loading

Fixes #3704.
Fixes #2593.

Notes/issues:

Fixes cplusplus/papers#781.
Fixes cplusplus/nbballot#298.
Fixes cplusplus/nbballot#258.
Fixes cplusplus/nbballot#154.
Fixes cplusplus/nbballot#300.
Fixes cplusplus/nbballot#283.
Fixes cplusplus/nbballot#282.
Fixes cplusplus/nbballot#214.
Fixes cplusplus/nbballot#215.
Fixes cplusplus/nbballot#216.
Fixes cplusplus/nbballot#290.
Fixes cplusplus/nbballot#160.
Fixes cplusplus/nbballot#161.
Fixes cplusplus/nbballot#329.
Fixes cplusplus/nbballot#330.
Fixes cplusplus/nbballot#331.
Fixes cplusplus/nbballot#340.
Fixes cplusplus/nbballot#243.
Fixes cplusplus/nbballot#210.
Fixes cplusplus/nbballot#295.
Fixes cplusplus/nbballot#176.
Fixes cplusplus/nbballot#299.
Fixes cplusplus/nbballot#278.
Fixes cplusplus/nbballot#222.
Fixes cplusplus/nbballot#199.
Fixes cplusplus/nbballot#179.
Fixes cplusplus/nbballot#200.

Fixes #3231.

@jensmaurer jensmaurer added this to the post-2020-02 milestone Feb 19, 2020
@jensmaurer jensmaurer changed the title Motions 2020 02 lwg 2 P2051R0 C++ Standard Library Issues to be moved in Prague Feb 19, 2020
@jwakely
Copy link
Member

jwakely commented Feb 19, 2020

Is everything in this branch also in motions-2020-02-lwg-3 ?

JohelEGP
JohelEGP suggested changes Feb 19, 2020
View reviewed changes
source/containers.tex Outdated Show resolved Hide resolved
source/containers.tex Show resolved Hide resolved
source/time.tex Outdated Show resolved Hide resolved
source/utilities.tex Outdated Show resolved Hide resolved
@JohelEGP
Copy link
Contributor

Is everything in this branch also in motions-2020-02-lwg-3 ?

Here's a diff: https://github.com/cplusplus/draft/compare/db3a6049bd7ae1244d0c6a09cfd3ea4b69cdf452..ea509911557a236702dccba48f2d2a2fa55322d0.

jensmaurer
jensmaurer requested changes Feb 21, 2020
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please augment each commit description with a "Also fixes NB US xxx (C++20 CD)." where applicable.

For example, LWG3319 fixes DE 344.
This is recorded in the source paper as "Addresses DE 344".

This is probably a situation where a force-push is desirable, despite these being straw-polls papers.

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Feb 21, 2020
@jensmaurer
Copy link
Member

jensmaurer commented Feb 21, 2020 •
edited
Loading

LWG 3280 also fixes US 302, but is not marked as such.
LWG 3286 also fixes US 304, but is not marked as such.
LWG 3284 also fixes US 262, but is not marked as such.
LWG 3304 also fixes US 217, but is not marked as such.
LWG 3292 also fixes US 286, but is not marked as such.

@jensmaurer jensmaurer changed the title P2051R0 C++ Standard Library Issues to be moved in Prague LWG Poll 2: P2051R0 C++ Standard Library Issues to be moved in Prague Feb 21, 2020
@burblebee
Copy link
Contributor Author

Is everything in this branch also in motions-2020-02-lwg-3 ?

Yes, lwg-3 was based on lwg-2 in order to resolve conflicts where issues from both motions changed the same wording.

@jensmaurer
Copy link
Member

jensmaurer commented Feb 21, 2020 •
edited
Loading

LWG 3281 also fixes US 284, but is not marked as such.
LWG 3285 also fixes US 156, but is not marked as such.
LWG 3291 also fixes US 287, but is not marked as such.

burblebee pushed a commit that referenced this pull request Feb 21, 2020
[allocator.uses.construction] Apply change suggested in #3748 to LWG3321
c962950
burblebee pushed a commit that referenced this pull request Feb 21, 2020
[allocator.uses.construction] Apply change suggested in #3748 to LWG3321
99a2866
@burblebee burblebee force-pushed the motions-2020-02-lwg-2 branch from 49a31a9 to 99a2866 Compare February 21, 2020 22:02
@burblebee
Copy link
Contributor Author

LWG 3280 also fixes US 302, but is not marked as such.
....

Thanks for pointing these out! Done - please recheck.

@burblebee burblebee removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Feb 21, 2020
@burblebee burblebee requested a review from jensmaurer February 21, 2020 22:04
@burblebee
Copy link
Contributor Author

LWG 3280 also fixes US 302, but is not marked as such.
....

Thanks for pointing these out! Done - please recheck.

Ugh - I did force push as Jens suggested, but that was probably a mistake - it will screw things up for @zygoloid when he tries to merge motions-2020-02-lwg-3 which was based on this :(.
@zygoloid, should I force-push motions-2020-02-lwg-3 also?

JohelEGP
JohelEGP reviewed Feb 21, 2020
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
burblebee pushed a commit that referenced this pull request Feb 22, 2020
[allocator.uses.construction] Apply change suggested in #3748 to LWG3321
46b0381
@burblebee burblebee force-pushed the motions-2020-02-lwg-2 branch from 1118b7e to 46b0381 Compare February 22, 2020 00:12
burblebee pushed a commit that referenced this pull request Feb 22, 2020
[allocator.uses.construction] Apply change suggested in #3748 to LWG3321
4185912
@burblebee burblebee force-pushed the motions-2020-02-lwg-2 branch from 46b0381 to 4185912 Compare February 22, 2020 01:34
@burblebee
Copy link
Contributor Author

LWG 3280 also fixes US 302, but is not marked as such.
....

Thanks for pointing these out! Done - please recheck.

Ugh - I did force push as Jens suggested, but that was probably a mistake - it will screw things up for @zygoloid when he tries to merge motions-2020-02-lwg-3 which was based on this :(.
@zygoloid, should I force-push motions-2020-02-lwg-3 also?

I'm going to go ahead and force push motions-2020-02-lwg-3 rebased on motions-2020-02-lwg-2, hope that's OK.

@JohelEGP
Copy link
Contributor

The force-pushed link shows that one of the changes was lost.

@burblebee burblebee mentioned this pull request Feb 23, 2020
Merged
@burblebee
Copy link
Contributor Author

burblebee commented Feb 25, 2020 •
edited
Loading

The force-pushed link shows that one of the changes was lost.

@JohelEGP The change from \exposid{iterator}::iterator_concept back to \exposid{iterator}::iterator_concept in [range.filter.iterator]/p2 was intentional, as that line was not changed by this motion (it was added in Nov. 2018 for P0896R4). There are several remaining iterators that should be should be \exposid{iterator}ed, but as a separate edit issue.

@JohelEGP
Copy link
Contributor

The force-pushed link shows that one of the changes was lost.

Oh? Which one?

https://github.com/cplusplus/draft/compare/46b038136e41f02ddeac66882ff53c5dff42a849..4185912a94c33ca909de86b59e0167b48a00b095#diff-0754a9e20af4b80758260aaad60a4d1eL3100

@burblebee
Copy link
Contributor Author

The force-pushed link shows that one of the changes was lost.

Oh? Which one?

https://github.com/cplusplus/draft/compare/46b038136e41f02ddeac66882ff53c5dff42a849..4185912a94c33ca909de86b59e0167b48a00b095#diff-0754a9e20af4b80758260aaad60a4d1eL3100

That was intentional, see my modified comment above (I guess we added comments here at the same time :) )

Dawn Perchik added 27 commits February 26, 2020 17:40
@zygoloid
LWG3307 std::allocator<void>().allocate(n)
b3d809a
@zygoloid
LWG3310 Replace SIZE_MAX with numeric_limits<size_t>::max()
31e9bb0 
Also fixes NB JP 218, JP 219 (C++20 CD).
@zygoloid
LWG3313 join_view::iterator::operator-- is incorrectly constrained
b561e61 
Also fixes NB US 294 (C++20 CD).
@zygoloid
LWG3315 Correct Allocator Default Behavior
ebd893b 
Also fixes NB US 162, US 163 (C++20 CD).
@zygoloid
LWG3316 Correctly define epoch for utc_clock / utc_timepoint
5518e72 
Also fixes NB GB 333 (C++20 CD).
@zygoloid
LWG3317 Incorrect operator<< for floating-point durations
8662855 
[time.duration.io] Combined paragraphs 3 and 4 with 2 (now 1)
to provide a complete definition for the placeholder "units_suffix"
introduced in the code in paragraph 2, and added punctuation.

Also fixes NB US 334 (C++20 CD).
@zygoloid
LWG3318 Clarify whether clocks can represent time before their epoch
bd57d9c 
Also fixes NB GB 335 (C++20 CD).
@zygoloid
LWG3319 Properly reference specification of IANA time zone database
41e73c4 
Also fixes NB DE 344 (C++20 CD).

[Bibliography] Changed punctuation to be consistent with existing entries.
@zygoloid
LWG3320 span::cbegin/cend methods produce different results than std:…
6faa9cf 
…:[ranges::]cbegin/cend

Also fixes NB PL 247 (C++20 CD).
@zygoloid
LWG3321 uninitialized_construct_using_allocator should use construct_at
f3199a9 
Also fixes NB US 213 (C++20 CD).
@zygoloid
LWG3323 has-tuple-element helper concept needs convertible_to
74487d3 
Also fixes NB GB 299 (C++20 CD).
@zygoloid
LWG3324 Special-case std::strong/weak/partial_order for pointers
099d550 
Also fixes NB CA 178 (C++20 CD).
@zygoloid
LWG3325 Constrain return type of transformation function for transfor…
a72b900 
…m_view

Also fixes NB US 303 (C++20 CD).
@zygoloid
LWG3326 enable_view has false positives
3777012 
[range.split.outer.value] The change to split_view was applied in LWG3276.

Also fixes NB DE 282 (C++20 CD).
@zygoloid
LWG3327 Format alignment specifiers vs. text direction
862d446 
Also fixes NB GB 225 (C++20 CD).
@zygoloid
LWG3329 totally_ordered_with both directly and indirectly requires co…
43e9566 
…mmon_reference_with

Also fixes NB US 201 (C++20 CD).
@zygoloid
LWG3330 Include <compare> from most library headers
abaa67f 
Added references to header synopsis on #includes.

Also fixes NB US 181 (C++20 CD).
@zygoloid
LWG3331 Define totally_ordered/_with in terms of partially-ordered-with
6f9fcd3 
Also fixes NB GB 202 (C++20 CD).
@zygoloid
LWG3332 Issue in [time.format]
68a6fd2
@zygoloid
LWG3338 Rename default_constructible to default_initializable
f426a14
@zygoloid
LWG3346 pair and tuple copy and move constructor have backwards speci…
84c829b 
…fication
@zygoloid
LWG3349 Missing __cpp_lib_constexpr_complex for P0415R1
1fca6b1
@zygoloid
LWG3350 Simplify return type of lexicographical_compare_three_way
4199b05
@zygoloid
LWG3351 ranges::enable_safe_range should not be constrained
6139589
@zygoloid
LWG3356 __cpp_lib_nothrow_convertible should be __cpp_lib_is_nothrow_…
901833b 
…convertible
@zygoloid
LWG3360 three_way_comparable_with is inconsistent with similar concepts
de58af8
@zygoloid
[allocator.uses.construction] Give a name to generic lambda type
090d7d8 
parameter to allow idiomatic use of std::forward.
@zygoloid zygoloid force-pushed the motions-2020-02-lwg-2 branch from b3d1dcd to 090d7d8 Compare February 27, 2020 01:51
@zygoloid zygoloid merged commit 68f753c into master Feb 27, 2020
@jensmaurer jensmaurer deleted the motions-2020-02-lwg-2 branch February 12, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsong-cpp timsong-cpp timsong-cpp left review comments

@JohelEGP JohelEGP JohelEGP requested changes

@jensmaurer jensmaurer Awaiting requested review from jensmaurer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2020-02
Development

Successfully merging this pull request may close these issues.

US163 16.05.3.5 [allocator. requirements] Default behavior for "construct" is "construct_at" LWG 3315 US162 16.05.3.5 [allocator.requirements] Default behavior for "destroy" is "destroy_at" LWG 3315 US156 16.04.2.2.6 p2 Ignore cv-qualifiers for customization point objects LWG 3285 [range.elements.overview] LWG 3302: range adaptor objects keys and values are unspecified [basic.lookup.classref]p1 CWG 682: Should allow alias-templates followed by '<'
CA178 17.11.07 [cmp.alg] Special-case std::strong/weak/partial_order for pointers LWG 3324 US181 [lib] include <compare> from most library headers LWG 3330 US201 18.05.4 totally_ordered_with both directly and indirectly requires common_reference_with LWG 3329 GB202 18.05.4 Define totally_ordered/_with in terms of partially-ordered-with LWG3331 US213 20.10.08.2 p17 uninitialized_construct_using_allocator should use construct_at LWG 3321
6 participants
@burblebee @jwakely @JohelEGP @jensmaurer @timsong-cpp @zygoloid