Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Match Method #329

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Delete Match Method #329

merged 1 commit into from
Nov 9, 2024

Conversation

cpisciotta
Copy link
Owner

@cpisciotta cpisciotta commented Nov 9, 2024

Delete the match method which first checks whether a given String input matches against a specified regular expression. Instead, attempt to extract the capture groups from a given regular expression. If the captureGroups method returns nil, it implies a failed match. Otherwise, a successful match is implied by a non-nil return value.

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.86%. Comparing base (ecb7a62) to head (43ccb3a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/XcbeautifyLib/Parser.swift 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   88.83%   88.86%   +0.03%     
==========================================
  Files          14       14              
  Lines        2302     2291      -11     
==========================================
- Hits         2045     2036       -9     
+ Misses        257      255       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpisciotta cpisciotta merged commit 8f738c5 into main Nov 9, 2024
13 checks passed
@cpisciotta cpisciotta deleted the charles/Match branch November 9, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant