Add failable init to CaptureGroup #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpisciotta
force-pushed
the
charles/CaptureGroupInit
branch
5 times, most recently
from
70c0fa1 to
96113ff
Compare
pepicrft
approved these changes
Jan 1, 2024
cpisciotta
force-pushed
the
charles/CaptureGroupInit
branch
from
911598b to
cb8afbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one step of a larger effort to simplify xcbeautify. This PR moves the logic to initialize CaptureGroups from captured regex groups to their respective CaptureGroups.