CodeSign line format #169
Merged
CodeSign line format #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpisciotta
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Thanks @pyrtsa! Appreciate the detailed feedback, your help fixing this, and backing it with a test 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
xcbeautifyfails to parseCodeSignlines correctly.Step(s) to reproduce. In a modularised Xcode project (don't know if that detail matters!),
xcodebuildproduces output lines of shape:Expected output. I would expect
xcbeautifyto produce output like:Actual output. Mind the special characters:
This PR fixes the above, while allowing the old format without any
(in target '*' ...)suffix to parse, as well. (The existingtestCodesign()unit test was left as is to assert that.)