-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ApplicationData datatype #485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good!
However, I figured this should target main, so this fix is available prior to your other PR (which otherwise still has a bugged commit).
Or, you fix the other PR by adding the custom serializer on the String?
, which then in this PR gets removed again. But, I tend to avoid that type of multiple modifications if better prerequisites are known. 🙂
I can rebase/move stuff for you if you want. Other than code style and commit order, I think these PRs are good to be merged.
Sounds good.
Yes please, and thanks. I try to avoid doing interactive rebase here (at least for now), as there is a chance I mess up everything and creates more work for both of us. 🙂 |
b4a6d3d
to
28d5e3a
Compare
This way, the serializer doesn't need to be specified on every field which requires `ApplicationDataSerializer`. Specifically, in case of inheritance, this prevents having to apply the serializer to all inheriting classes on base properties which need it.
28d5e3a
to
77f9bf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just rebased on develop and removed the use of ApplicationData
in the commits which aren't yet merged to the develop branch.
I also slightly reworked the ApplicationData
and ApplicationDataSerializer
documentation to avoid redundancies. The type now already documents the purpose, so no real need to reiterate on that fully on the serializer.
As discussed in #484, introducing a new datatype to hold
applicationData
and set default serializer toApplicationDataSerializer
. This way we don't need to specify the serializer used everytime we useapplicationData
.Changes:
ApplicationData
holds aString
fielddata
.ApplicationDataSerializer
, a not null String value is expected for fielddata
applicationData
are now type ofApplicationData?