-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case for getActiveParticipationInvitation with multiple part… #483
Add test case for getActiveParticipationInvitation with multiple part… #483
Conversation
...ore/src/commonTest/kotlin/dk/cachet/carp/deployments/application/ParticipationServiceTest.kt
Outdated
Show resolved
Hide resolved
...ore/src/commonTest/kotlin/dk/cachet/carp/deployments/application/ParticipationServiceTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep the test focused, I added a createTwoDevicesAndRolesProtocol()
test helper, which is likely to also be useful in future test cases.
I added additional assertions to verify both accounts, as well as the devices they were assigned.
Lastly, I fixed to code styles to follow the non-idiomatic style of this project. ;) I think the static checker only checks for it in main sources, or it failed here. Either way: I'll gladly polish minor stuff like that in any PR you send along. :)
dafaf76
to
e122e42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an exception for test sources for detekt flagging destructuring operations > 3 fields.
Thank you for the explanation and commentnt.
I thought about re-using I'll be adopting to the decision making logic (and maybe code style here) |
…icipation