-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Website as a device #465
Conversation
6fa83be
to
71ba790
Compare
I decided not to include any static typing and just go with strings for now. |
carp.common/src/commonMain/kotlin/dk/cachet/carp/common/application/URL.kt
Outdated
Show resolved
Hide resolved
carp.common/src/commonMain/kotlin/dk/cachet/carp/common/application/URL.kt
Outdated
Show resolved
Hide resolved
carp.common/src/commonMain/kotlin/dk/cachet/carp/common/application/URL.kt
Outdated
Show resolved
Hide resolved
carp.common/src/commonTest/kotlin/dk/cachet/carp/common/application/URLTest.kt
Outdated
Show resolved
Hide resolved
carp.common/src/commonMain/kotlin/dk/cachet/carp/common/application/devices/WebBrowser.kt
Outdated
Show resolved
Hide resolved
carp.common/src/commonMain/kotlin/dk/cachet/carp/common/application/devices/WebBrowser.kt
Outdated
Show resolved
Hide resolved
carp.common/src/commonMain/kotlin/dk/cachet/carp/common/application/devices/WebBrowser.kt
Outdated
Show resolved
Hide resolved
carp.common/src/commonMain/kotlin/dk/cachet/carp/common/application/tasks/WebTask.kt
Outdated
Show resolved
Hide resolved
carp.common/src/commonTest/kotlin/dk/cachet/carp/common/application/devices/WebBrowserTest.kt
Outdated
Show resolved
Hide resolved
71ba790
to
0a54351
Compare
I also decided to rename |
57d30cc
to
2bbde28
Compare
carp.common/src/commonMain/kotlin/dk/cachet/carp/common/application/devices/Website.kt
Outdated
Show resolved
Hide resolved
9451003
to
8bc4e40
Compare
Thank you for adding this @xelahalo ! To have something which requires no further discussion and can be merged now, I adjusted the PR as follows:
|
I also added a convenience URL classes and moved the things that was in WebTask to a common place. I tried to keep things backwards compatible but someone should check it out. I am also unsure about the schemas.