Fix: JS/TS access to snapshot properties #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The properties `id`, `createdOn`, and `version` of snapshots couldn't be accessed through JS/TypeScript since they were defined on a base `Snapshot` interface which couldn't be JS exported from Kotlin due to an unsupported `Instant` type. But, by suppressing a warning the base `Snapshot` interface can in fact be exported, and the resulting TypeScript code compiles since the custom build pipeline already modifies generated TypeScript sources to support `Instant`.
jakdan99
approved these changes
Feb 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The properties
id,createdOn, andversionof snapshots couldn't be accessed through JS/TypeScript since they were defined on a baseSnapshotinterface which couldn't be JS exported from Kotlin due to an unsupportedInstanttype.But, by suppressing a warning the base
Snapshotinterface can in fact be exported, and the resulting TypeScript code compiles since the custom build pipeline already modifies generated TypeScript sources to supportInstant.Closes #454