Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kotlin 1.9.10 and other dependencies #447

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Conversation

Whathecode
Copy link
Member

@Whathecode Whathecode commented Oct 21, 2023

The new Kotlin version seems to require IntelliJ 2023.

And, as usual, the JS facades had to be updated; serializer() access through companion objects now also seems garbled, but luckily always to .o14(), so I could add a new facade to access serializers.

Lastly, a detekt upgrade resulted in some new formatting violations which were fixed.

The new version seems to require IntelliJ 2023. And, as usual, the JS facades had to be updated; `serializer()` access through companion objects now also seems garbled, but luckily always to `.o14()`, so I could add a new facade to access serializers.
@Whathecode Whathecode changed the title Upgrade to Kotlin 1.9.10 and other libraries Upgrade to Kotlin 1.9.10 and other dependencies Oct 22, 2023
Although there is a later version of `@typescript-eslint/typescript-estree` available, using any later version will require updating to a newer module resolution than "umd": typescript-eslint/typescript-eslint#7284
Warnings are now treated for all compilations, also test compilations, for which two fixes of missing `@Target` attributes were added.

And, refactored warning configuration to be centralized in a single place.
@Whathecode
Copy link
Member Author

Whathecode commented Nov 5, 2023

Kotlin 1.9.20 has been released, but updating to it currently is blocked by what seems to be a new TypeScript generation bug.

For future reference, it also requires adding it.freeCompilerArgs.add('-Xexpect-actual-classes') // https://youtrack.jetbrains.com/issue/KT-61573 to build.gradle where currently the other optIn's live.

Copy link
Collaborator

@xelahalo xelahalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, most of it was just formatting, sorry for the late review!

@Whathecode Whathecode merged commit 787315c into develop Nov 9, 2023
3 checks passed
@Whathecode Whathecode deleted the upgrade-kotlin branch November 9, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants