pyproject.toml: include subpackages in setuptools config #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glob patterns (include/exclude) must match the entire package name to take effect, so we need to add a wildcard pattern for subpackages. Otherwise, any wheels built won't include subpackages (like
pathspec.patterns
) and things will break >.<To see the impact of the invalid configuration simply try the following:
pip install https://github.com/cpburnz/python-path-specification/archive/master.zip
(pip will build a wheel from source and then install it)python -c "import pathspec"
ImportError: cannot import name 'patterns' from partially initialized module 'pathspec'
Thank you for maintaining pathspec by the way! 🖤 I am one of the maintainers of Black which uses pathspec and it's been great. I noticed this issue since I run black's test suite daily using the development versions of our dependencies (to catch issues early-on, before they get released).