[VO-428] feat: Call resolve on all Android's path for hide and show, and improve debug #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation was not handling parallel calls correctly As not all path are resolving the promise, then the JS call would hang in some scenario
In order to improve feedback on what is done by the library, we want to return strings instead of `true` when the BootSplash is not shown or hidden
In order to ease debug, we want to add some console logs Those logs would allow to track the bootsplashNames array Those are native logs, so they would not appear on the RN console, instead use XCode console, `adb logcat ...` or Flipper
Ldoppea
changed the title
Ldoppea
changed the title
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 28, 2024
`react-native-bootsplash` has been upgraded to retrieve a fix that ensures the `show` and `hide` methods always resolve their promises Related PR: cozy/react-native-bootsplash#4
1 task
Ldoppea
changed the title
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 29, 2024
`react-native-bootsplash` has been upgraded to retrieve a fix that ensures the `show` and `hide` methods always resolve their promises Related PR: cozy/react-native-bootsplash#4
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 29, 2024
`react-native-bootsplash` has been upgraded to retrieve a fix that ensures the `show` and `hide` methods always resolve their promises Related PR: cozy/react-native-bootsplash#4
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 29, 2024
`react-native-bootsplash` has been upgraded to retrieve a fix that ensures the `show` and `hide` methods always resolve their promises Related PR: cozy/react-native-bootsplash#4
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 29, 2024
`react-native-bootsplash` has been upgraded to retrieve a fix that ensures the `show` and `hide` methods always resolve their promises Related PR: cozy/react-native-bootsplash#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation was not handling parallel calls correctly
As not all path are resolving the promise, then the JS call would hang
in some scenario
This PR also add more details in Android methods result so we can check if the splashscreen is hidden or not. Some logs have also been added to improve debugging experience
Related PR: cozy/cozy-flagship-app#1181