feat: Add a shared Stylus configuration to build cozy application #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
requested review from
JF-Cozy,
Merkur39,
zatteo and
doubleface
as code owners
JF-Cozy
approved these changes
Feb 4, 2025
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "name": "stylus-config-cozy-app", | |||
| "version": "0.0.0", | |||
There was a problem hiding this comment.
c'est incrémenté automatiquement par lerna il me semble. En tout cas je me suis basé sur cette PR: #2628
zatteo
reviewed
Feb 4, 2025
| "dependencies": { | ||
| }, | ||
| "peerDependencies": { | ||
| } |
There was a problem hiding this comment.
No need to add stylint in peerDeps ?
zatteo
approved these changes
Feb 4, 2025
This configuration is copied from cozy-scripts Because we are migrating our app bundler from create-cozy-app to Rsbuild, we will remove dependences to cozy-script from our app and so we will lose access to the embeded .stylintrc file To prevent this we want to extract this `.stylintrc` file to its own config repository. Then Rsbuild project will be able to use it by installing `stylus-config-cozy-app` module
Ldoppea
force-pushed
the
feat/stylus-config
branch
from
274e4a9 to
68e30c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configuration is copied from cozy-scripts
Because we are migrating our app bundler from create-cozy-app to Rsbuild, we will remove dependences to cozy-script from our app and so we will lose access to the embeded .stylintrc file
To prevent this we want to extract this
.stylintrcfile to its own config repository. Then Rsbuild project will be able to use it by installingstylus-config-cozy-appmodule