[DAT-41] Fix transitions #1192
Merged
[DAT-41] Fix transitions #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultranvan
force-pushed
the
fix-transitions
branch
from
a55034f to
d1bd917
Compare
Crash--
reviewed
Mar 21, 2024
| @@ -292,5 +293,5 @@ export const startOpenPathUploadAndPipeline = async ({ | |||
| Log('Failed openpath processing: ' + err) | |||
| log.error(err) | |||
| } | |||
| return | |||
| return uploadedCount | |||
There was a problem hiding this comment.
you should update the jsdoc to reflect that change
There was a problem hiding this comment.
Right, it's done
Ldoppea
reviewed
Mar 21, 2024
Ldoppea
reviewed
Mar 21, 2024
paultranvan
force-pushed
the
fix-transitions
branch
2 times, most recently
from
33bd281 to
8972e71
Compare
Consider this scenario: - A location point P1 is produced at 12:00:00 (T1), the last of a trip. - An upload is done, with the stop transitions set at T1 + 1s = 12:00:01 - P2 is produced at 12:00:01 (T2), the first of new trip - At upload time, the start transitions will be set at T2 - 1s = 12:00:00 Then, the start transition timestamp of the new trip will be before the stop transition of the previous trip, which is not possible, and will be discarded by the server, which will result in a missing trip. To solve this, we now add/substract 1ms to the transitions w.r.t. to the first or last location point. This should prevent overlapping transitions, as long as locations between 2 trips are not produced in the same ms
paultranvan
force-pushed
the
fix-transitions
branch
from
8972e71 to
4d190e8
Compare
Ldoppea
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Before merging this PR, the following things must have been done if relevant: