feat: Bump app version to 1.1.24, fix MaBulle icon and fix MaBulle build #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Ldoppea
commented
Mar 12, 2024
Ldoppea
commented
Ldoppea
changed the title
Ldoppea
added a commit
that referenced
this pull request
Mar 12, 2024
In b056a90 we added code to dynamically remove IAP package using white_label mechanism This correctly removed the IAP package and allowed to build the app But since then, we added some react-native components that use the module and would break when removing the IAP package (react-native module is available, but the native part is not loaded) To make them work without IAP package, we choose to move the import behind a proxy file. Then we can override this file using white_labels and instead import stubbed methods The mandatory methods are `withIAPContext` and `useIAP` that wrap the entire components and `getSubscriptions` that is used to enable/disable IAP features Other methods can still be exported as is as they would never be called when IAP features are disabled Related commit: b056a90 Related PR: #1188
acezard
approved these changes
Mar 12, 2024
In b056a90 we added code to dynamically remove IAP package using white_label mechanism This correctly removed the IAP package and allowed to build the app But since then, we added some react-native components that use the module and would break when removing the IAP package (react-native module is available, but the native part is not loaded) To make them work without IAP package, we choose to move the import behind a proxy file. Then we can override this file using white_labels and instead import stubbed methods The mandatory methods are `withIAPContext` and `useIAP` that wrap the entire components and `getSubscriptions` that is used to enable/disable IAP features Other methods can still be exported as is as they would never be called when IAP features are disabled Related commit: b056a90 Related PR: #1188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.