[VO-258] feat: Re-enable File logger #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
changed the title
zatteo
approved these changes
Mar 11, 2024
In #1183 we disabled the new File logger mechanism due to a side effect with react-native-background-geolocation This was because react-native-file-logger would reset all log appenders during initialisation which would prevent native-background-geolocation to work This commit applies the fix from BeTomorrow/react-native-file-logger#66 (we cannot update the lib as we are still using ReactNative old architecture) Related PR: #1183 Related issue: BeTomorrow/react-native-file-logger#64 Related issue: BeTomorrow/react-native-file-logger#66
Ldoppea
force-pushed
the
feat/re_enable_file_logger
branch
from
d7370b7 to
c455046
Compare
Ldoppea
added a commit
that referenced
this pull request
Apr 13, 2024
In #1187 we fixed the new File logger initialization on Android as it would break the react-native-background-geolocation plugin's internal File logger This was because react-native-file-logger would reset all log appenders during initialisation which would prevent native-background-geolocation to work This bug was also present in iOS but appeared latter so we did not notice it and so we did not fix it on initial PR This commit applies the fix from BeTomorrow/react-native-file-logger#69 (we cannot update the lib as we are still using ReactNative old architecture) Related PR: #1187 Related PR: #1183 Related issue: BeTomorrow/react-native-file-logger#64 Related issue: BeTomorrow/react-native-file-logger#66 Related issue: BeTomorrow/react-native-file-logger#69
Ldoppea
added a commit
that referenced
this pull request
Apr 15, 2024
In #1187 we fixed the new File logger initialization on Android as it would break the react-native-background-geolocation plugin's internal File logger This was because react-native-file-logger would reset all log appenders during initialisation which would prevent native-background-geolocation to work This bug was also present in iOS but appeared latter so we did not notice it and so we did not fix it on initial PR This commit applies the fix from BeTomorrow/react-native-file-logger#69 (we cannot update the lib as we are still using ReactNative old architecture) Related PR: #1187 Related PR: #1183 Related issue: BeTomorrow/react-native-file-logger#64 Related issue: BeTomorrow/react-native-file-logger#66 Related issue: BeTomorrow/react-native-file-logger#69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1183 we disabled the new File logger mechanism due to a side effect with react-native-background-geolocation
This was because react-native-file-logger would reset all log appenders during initialisation which would prevent native-background-geolocation to work
This commit applies the fix from BeTomorrow/react-native-file-logger#66 (we cannot update the lib as we are still using ReactNative old architecture)
Related PR: #1183
Related issue: BeTomorrow/react-native-file-logger#64
Related issue: BeTomorrow/react-native-file-logger#66