fix: Fix plural translations by importing missing locale-data #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, I did not understand why plural translations did not work on iOS. They were returning the key instead of the pluralized translation. I duplicated the translations to support the JSON v3 fallback but it still did not work properly. They were always returning the singular key. Here, I found that the root of the issue was the missing locale-data import needed by 'intl' and 'intl-pluralrules' polyfill. So plural translations works and I removed the duplicate translations.
|
Related for information : i18next/i18next#2155 |
acezard
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I did not understand why plural translations did not work on iOS. They were returning the key instead of the pluralized translation. I duplicated the translations to support the JSON v3 fallback but it still did not work properly. They were always returning the singular key.
Here, I found that the root of the issue was the missing locale-data import needed by 'intl' and 'intl-pluralrules' polyfill.
So plural translations works and I removed the duplicate translations.
Checklist
Before merging this PR, the following things must have been done if relevant: