fix: Add by default the flagship UA on SupervisedWebview #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw in our log that some requests didn't have the flagship UA. Mostly the ones on the PasswordView: ` 2024-02-06T06:22:02.095Z 200 Mozilla GET https://XXX.mycozy.cloud/assets/fonts/Lato-Bold.immutable.woff2 ` It was hard for us to know whether a user had only used the flagship app or not. So instead of adding the userAgent on each webview, I decided to add it to the SupervisedWebview since each webview rely on it. Like that, if we want to override the props, we can, but by default the flagship UA agent is set. So I removed all the `applicationNameForUserAgent` that call the SupervisedWebview
Ldoppea
approved these changes
Feb 8, 2024
acezard
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw in our log that some requests didn't have the flagship UA. Mostly the ones on the PasswordView:
2024-02-06T06:22:02.095Z 200 Mozilla GET https://XXX.mycozy.cloud/assets/fonts/Lato-Bold.immutable.woff2It was hard for us to know whether a user had only used the flagship app or not.
So instead of adding the userAgent on each webview, I decided to add it to the SupervisedWebview since each webview rely on it. Like that, if we want to override the props, we can, but by default the flagship UA agent is set.
So I removed all the
applicationNameForUserAgentthat call the SupervisedWebviewI didn't test anything.
Checklist
Before merging this PR, the following things must have been done: