fix: Do not log geolocation plugin log in sentry #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasSentryEnabled is set before toggleLocalSentry is called. So in Sentry configuration, enabled stays to false.
Ldoppea
approved these changes
Feb 5, 2024
Our config only send warn and error logs to Sentry. But when an error log is sent to Sentry, previous logs, including info logs, are also sent with it (in the "breadcrumb" field from Sentry). This is an issue because we currently log geolocation data as info logs. So sometimes geolocation data can be sent to Sentry if it is logged just before an error. devlog solves the issue because it does NOT log in production mode. geolocation plugin log will still be available in dev console and through the "Send logs" button in coachco2.
zatteo
force-pushed
the
fix/geolocation-data-log
branch
from
b5cf1d7 to
6c60ca7
Compare
Updated with a more complete commit message 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.