fix: reset cloud webview on connection retrieval (VO-269) #1149
Conversation
acezard
force-pushed
the
fix--reset-cloud-webview-after-connection-retrieval
branch
from
28a766d to
1e253a1
Compare
This will avoid a perpetual error state. We reset the webview state on connection so it doesn't stay stuck
acezard
force-pushed
the
fix--reset-cloud-webview-after-connection-retrieval
branch
from
1e253a1 to
0ad99b6
Compare
| isOffline && | ||
| NetService.handleOfflineWithCallback(() => { | ||
| webviewRef.current?.reload() // Have to reload the webview when the user is back online or it will stay errored | ||
| navigationRef.navigate(routes.welcome) // Go back to the welcome screen to leave the offline screen (offline screen should be refactored to be a modal) |
There was a problem hiding this comment.
offline screen should be refactored to be a modal
Can't we take the opportunity to do it? If @Ldoppea is agreed with this take?
There was a problem hiding this comment.
I think he would agree since he prefers modal based approach to route based like here.
I could do it if we have enough time, I think is needed something like half a day to one day.
There was a problem hiding this comment.
Actually, i'm not sure about what is the best option for the offline screen.
My arguments for using modals for lock screen or clouderyOffer screen is that they should not have any impact on the application state when displayed.
Here the offline screen is often displayed when the webviews are broken. So it may be useful to have a navigation that enforce reseting the view.
That being said, by reading your reload() call, I understand that state was not reseted with the current way of handling offline?
To sumarize, I see 2 approaches:
- A screen that unmount the current screen while displaying the offline one
- pro: we ensure the screen is reset and that no "offline" related bug remains
- cons: we need to track context to reapply it when connexion is restored
- A modal that keep the app's state intact
- pro: we don't need to track context
- cons: the screen need to reset itself when connexion is restored (this may be tricky is some screens)
acezard
deleted the
fix--reset-cloud-webview-after-connection-retrieval
branch
This will avoid a perpetual error state.
We reset the webview state on connection so it doesn't stay stuck