fix: always hide splashscreen on wakeup (VO-267) #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On appStart the homeview will hide the splashscreen On wakeup, it is more ambiguous so we force it
Crash--
reviewed
Jan 22, 2024
| @@ -32,6 +36,10 @@ const handleWakeUp = async ( | |||
| } | |||
|
|
|||
| await handleSecurityFlowWakeUp(client) | |||
|
|
|||
| // On appStart the homeview will hide the splashscreen | |||
There was a problem hiding this comment.
even if this is not the "home cozy app" displayed inside the homeview?
There was a problem hiding this comment.
@acezard I think that I already answered this question during a visio call with @Crash--
For now HomeView only render the cozy-home app. And if, in the future, we plan to replace this in some context, then calling hideSplashScreen() should be part of the contract.
However if I remember correctly, @Crash-- was thinking about default cozy-app. Then here we display them in the CozyAppScreen. In that case, the HomeView will be still displayed in the background.
Ldoppea
reviewed
Jan 26, 2024
|
|
||
| // On appStart the homeview will hide the splashscreen | ||
| // On wakeup, it is more ambiguous so we force it | ||
| if (!isAppStart) await hideSplashScreen(lockScreens.LOCK_SCREEN) |
There was a problem hiding this comment.
nit: If you use lockScreens.LOCK_SCREEN enum here, then you should use it also in line 23
|
|
||
| // On appStart the homeview will hide the splashscreen | ||
| // On wakeup, it is more ambiguous so we force it | ||
| if (!isAppStart) await hideSplashScreen(lockScreens.LOCK_SCREEN) |
There was a problem hiding this comment.
I'm wondering if this hideSplashScreen(lockScreens.LOCK_SCREEN) should be called in LockScreenWrapper instead.
We can put it next to hideSplashScreen() so we hide both the initial SplashScreen and the LockScreen one.
I think this should work because other "non lock" scenarios already hides this splashscreen on SecurityService:61 and SecurityService:207
Ldoppea
added a commit
that referenced
this pull request
Feb 28, 2024
With previous implementation we blindly hid the LOCK_SCREEN's splash screen when the app would resume This was made in #1139 to ensure we don't forget any path But we found that this approach is too naive as it would fail when the app requests a restart This is because, on Android, when the app requests a restart, the current Activity is not directly destroyed and the app react as if it was sent to `background`. In that scenario the hook would show the LOCK_SCREEN's splash screen and then would fail to hide it, as it would consider the app is starting from scratch This side effect has been fixed in previous commit as the entire component's tree is now unmount before restart and so the LOCK_SCREEN is not shown anymore. But we still want to revert to specificly placed call instead of global one, so we have better control on what is happening Related PR: #1139
Ldoppea
added a commit
that referenced
this pull request
Feb 29, 2024
With previous implementation we blindly hid the LOCK_SCREEN's splash screen when the app would resume This was made in #1139 to ensure we don't forget any path But we found that this approach is too naive as it would fail when the app requests a restart This is because, on Android, when the app requests a restart, the current Activity is not directly destroyed and the app react as if it was sent to `background`. In that scenario the hook would show the LOCK_SCREEN's splash screen and then would fail to hide it, as it would consider the app is starting from scratch This side effect has been fixed in previous commit as the entire component's tree is now unmount before restart and so the LOCK_SCREEN is not shown anymore. But we still want to revert to specificly placed call instead of global one, so we have better control on what is happening Related PR: #1139
Ldoppea
added a commit
that referenced
this pull request
Feb 29, 2024
With previous implementation we blindly hid the LOCK_SCREEN's splash screen when the app would resume This was made in #1139 to ensure we don't forget any path But we found that this approach is too naive as it would fail when the app requests a restart This is because, on Android, when the app requests a restart, the current Activity is not directly destroyed and the app react as if it was sent to `background`. In that scenario the hook would show the LOCK_SCREEN's splash screen and then would fail to hide it, as it would consider the app is starting from scratch This side effect has been fixed in previous commit as the entire component's tree is now unmount before restart and so the LOCK_SCREEN is not shown anymore. But we still want to revert to specificly placed call instead of global one, so we have better control on what is happening Related PR: #1139
Ldoppea
added a commit
that referenced
this pull request
Feb 29, 2024
With previous implementation we blindly hid the LOCK_SCREEN's splash screen when the app would resume This was made in #1139 to ensure we don't forget any path But we found that this approach is too naive as it would fail when the app requests a restart This is because, on Android, when the app requests a restart, the current Activity is not directly destroyed and the app react as if it was sent to `background`. In that scenario the hook would show the LOCK_SCREEN's splash screen and then would fail to hide it, as it would consider the app is starting from scratch This side effect has been fixed in previous commit as the entire component's tree is now unmount before restart and so the LOCK_SCREEN is not shown anymore. But we still want to revert to specificly placed call instead of global one, so we have better control on what is happening Related PR: #1139
Ldoppea
added a commit
that referenced
this pull request
Feb 29, 2024
With previous implementation we blindly hid the LOCK_SCREEN's splash screen when the app would resume This was made in #1139 to ensure we don't forget any path But we found that this approach is too naive as it would fail when the app requests a restart This is because, on Android, when the app requests a restart, the current Activity is not directly destroyed and the app react as if it was sent to `background`. In that scenario the hook would show the LOCK_SCREEN's splash screen and then would fail to hide it, as it would consider the app is starting from scratch This side effect has been fixed in previous commit as the entire component's tree is now unmount before restart and so the LOCK_SCREEN is not shown anymore. But we still want to revert to specificly placed call instead of global one, so we have better control on what is happening Related PR: #1139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On appStart the homeview will hide the splashscreen
On wakeup, it is more ambiguous so we force it