[VO-171] fix: Force android tools version on CI when signing APK #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since January 8 the `ubuntu-latest` image excludes Android SDKs prior to version 31 By default the `r0adkll/sign-android-release` package uses Android SDK 29. So the build would fail In order to fix that, we can set the `BUILD_TOOLS_VERSION` env variable to define which version `r0adkll/sign-android-release` should use Related doc: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md Related issue: r0adkll/sign-android-release#84
Ldoppea
changed the title
zatteo
approved these changes
Jan 19, 2024
acezard
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since January 8 the
ubuntu-latestimage excludes Android SDKs prior to version 31By default the
r0adkll/sign-android-releasepackage uses Android SDK 29. So the build would failIn order to fix that, we can set the
BUILD_TOOLS_VERSIONenv variable to define which versionr0adkll/sign-android-releaseshould useRelated doc:
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md
Related issue: r0adkll/sign-android-release#84
Important
This seems to also fix the bug we had on
prodbuild that would instantaneously crash when opening them on Android devices