Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Sentry #1134

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat: Update Sentry #1134

merged 1 commit into from
Jan 19, 2024

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Jan 18, 2024 •
edited
Loading

Latest release ✅
RN 0.72 ready ✅
New arch ready ✅
Profiling ready ✅

Tested with a .ipa built with CI.

Crash--
Crash-- approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@Crash-- Crash-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think there is also a missing piece, I don't know if the flagship is concerned, but we missed the sourcemap upload to sentry. Without the sourcemap, the stacktrace is diffcult to read (I know this has nothing to do with this PR ;))

@zatteo zatteo merged commit c1614b8 into master Jan 19, 2024
1 check passed
@zatteo zatteo deleted the feat/update-sentry branch January 19, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crash-- Crash-- Crash-- approved these changes

@acezard acezard Awaiting requested review from acezard acezard is a code owner

@Ldoppea Ldoppea Awaiting requested review from Ldoppea Ldoppea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zatteo @Crash--