[DAT-26] feat: Pass stored webhook to pipeline execution #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing a webhook URL to the pipeline execution request, the server will request it after its completion. This webhook is typically the openpath trips fetching. Thanks to this, we will now be able to retrieve the trips as soon as they are produced.
zatteo
reviewed
Jan 19, 2024
| const webhookQuery = buildServiceWebhookQuery() | ||
| const webhookResp = useQuery(webhookQuery.definition, webhookQuery.options) | ||
|
|
||
| if (Array.isArray(webhookResp.data) && webhookResp.data.length > 0) { |
There was a problem hiding this comment.
nit: You can webhookResp?.data?.length > 0
There was a problem hiding this comment.
I actually added the Array.isArray because typescript was complaining with: Property 'length' does not exist on type 'object | any[]'.
zatteo
approved these changes
Jan 19, 2024
|
Very nice a huge step in user experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a webhook URL to the pipeline execution request, the server
will request it after its completion.
This webhook is typically the openpath trips fetching. Thanks to this,
we will now be able to retrieve the trips as soon as they are produced.
Related to cozy/coachCO2#370