Check geolocation quota at trip end #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultranvan
reviewed
Jan 15, 2024
paultranvan
reviewed
Jan 15, 2024
paultranvan
reviewed
Jan 15, 2024
paultranvan
approved these changes
Jan 15, 2024
Geolocation quota is currently only checked at startup. So if the user keep the app in background for a long time, he will be able to use geolocation for a long time even if he should not use it anymore. We try to keep a strong isolation in the geolocation tracking service because it is used by cozy-flagship-app and CozyGPSMemory. To be able to listen to trip end events from the geolocation service, so from the heart of CozyGPSMemory, we add an event emitter. This event emitter will emit a trip end, which can be listened to by cozy-flagship-app.
**About the expected behavior** We want to do this request until we have a timeserie. As soon as we have a timeserie, we do not need anymore to do this request. I think this behavior is not possible to model in cozy-client. So I do the request as long as the result is [], and then when there is a timeserie, I store the timeserie in AsyncStorage. And if there is a timeserie in AsyncStorage, I don't do the request. **About this commit** With the cozy-client store and 24 hours cache as before this commit, I could store [] in the cache which is NOT what I want.
zatteo
force-pushed
the
fix/check-geolocation-quota-at-trip-end
branch
from
ee880b7 to
f056032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think about this event implementation @Ldoppea and @paultranvan.
It means that we must install "events" package on CozyGPSMemory but that's all.