Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the use of unexpected 'warning' log level #1067

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

doubleface
Copy link
Contributor

And replace it with 'warn'

See c6d28d8/src/libs/ReactNativeLauncher.js#L114
for reference

Or else warning messages are displayed as simple log level messages

Checklist

Before merging this PR, the following things must have been done:

  • Faithful integration of the mockups at all screen sizes
  • Tested on iOS
  • Tested on Android
  • Localized in English and French
  • All changes have test coverage
  • Updated README & CHANGELOG, if necessary

And replace it with 'warn'

See c6d28d8/src/libs/ReactNativeLauncher.js#L114
for reference

Or else warning messages are displayed as simple log level messages
@doubleface doubleface merged commit 180cb9e into master Dec 13, 2023
1 check passed
@doubleface doubleface deleted the fix/warningwarn branch December 13, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants