Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid to have deformed webview warning logs #1055

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

doubleface
Copy link
Contributor

when a webview emits a warning log, we get a log which looks like this :

 LOG  CozyWebView [Console HomeView] w a r n :   % c c o z y - s t a c k
 - c l i e n t   D e p r e c a t e d :   i n   n e x t   v e r s i o n s
 o f   c o z y - c l i e n t ,   i t   w i l l   n o t   b e   p o s s i
 b l e   t o   q u e r y   s e t t i n g s   w i t h   a n   i n c o m p
 l e t e   i d

   -   Q ( ' i o . c o z y . s e t t i n g s ' ) . g e t B y I d ( ' i n
   s t a n c e ' )
    +   Q ( ' i o . c o z y . s e t t i n g s ' ) . g e t B y I d ( ' i
    o . c o z y . s e t t i n g s . i n s t a n c e ' ) , c o l o r :
    # f f f ;   b a c k g r o u n d :   # b b b b 0 0 ;

This fix allows to get a normal display of the logs

Checklist

Before merging this PR, the following things must have been done:

  • Faithful integration of the mockups at all screen sizes
  • Tested on iOS
  • Tested on Android
  • Localized in English and French
  • All changes have test coverage
  • Updated README & CHANGELOG, if necessary

when a webview emits a warning log, we get a log which looks like this :

```
 LOG  CozyWebView [Console HomeView] w a r n :   % c c o z y - s t a c k
 - c l i e n t   D e p r e c a t e d :   i n   n e x t   v e r s i o n s
 o f   c o z y - c l i e n t ,   i t   w i l l   n o t   b e   p o s s i
 b l e   t o   q u e r y   s e t t i n g s   w i t h   a n   i n c o m p
 l e t e   i d

   -   Q ( ' i o . c o z y . s e t t i n g s ' ) . g e t B y I d ( ' i n
   s t a n c e ' )
    +   Q ( ' i o . c o z y . s e t t i n g s ' ) . g e t B y I d ( ' i
    o . c o z y . s e t t i n g s . i n s t a n c e ' ) , c o l o r :
    # f f f ;   b a c k g r o u n d :   # b b b b 0 0 ;

```

This fix allows to get a normal display of the logs
Copy link
Member

@Ldoppea Ldoppea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the line endings changed as the entire file is marked as edited. Can you check if this is because the olds line endings were wrong if this part should be revert?

The fix part is good

@doubleface
Copy link
Contributor Author

I confirm line endings were wrong and my code editor fixed it automatically. I checked and vscode and vim do the same thing here.

@doubleface doubleface merged commit 790e90c into master Dec 8, 2023
1 check passed
@doubleface doubleface deleted the fix/warnLogs branch December 8, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants