feat: Move LauncherView to App.js #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
reviewed
Dec 5, 2023
doubleface
force-pushed
the
feat/LauncherInCozyWebview
branch
from
6c321f8 to
19c8df2
Compare
6 tasks
Ldoppea
reviewed
Dec 5, 2023
| onClose={(): void => { | ||
| setConcurrentKonnector(undefined) | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call | ||
| launcherEvent.emit('launchResult', { cancel: true }) |
There was a problem hiding this comment.
I'm not sure to understand this one. How do we distinguish this launchResult from the one that would be emited by the "already running" connector?
There was a problem hiding this comment.
Actually, there is no distinction. The current account/konnector opened in harvest will receive this message. And since the current opened connector is the one which caused to open the "already running" connector, this is the one we want to cancel.
doubleface
force-pushed
the
feat/LauncherInCozyWebview
branch
2 times, most recently
from
5e9989d to
0af81fa
Compare
added 2 commits
December 6, 2023 10:59
This is needed to allow mespapiers app to control clisk konnectors. Also needed to convert launcher context to a global context to allow it to be used in multiple places (CozyWebView, App)
When running a second clisk konnector, the dialog preventing the second run is displayed. But the FlowProvider in harvest will keep its running state, blocking the user to do anything else. Now we cancel this running state (since no second konnector is actually running).
doubleface
force-pushed
the
feat/LauncherInCozyWebview
branch
from
0af81fa to
d5afa34
Compare
Ldoppea
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to allow mespapiers app to control clisk konnectors.
Also needed to convert launcher context to a global context to allow it
to be used in multiple places (CozyWebView, App)
Checklist
Before merging this PR, the following things must have been done: