refactor: use only one source of online events #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove direct NetInfo use in NetStatusBoundary (use service instead) - Add more error handling - Use hidesplashscreen inside error screen instead of provider - Refactor waitForOnline to accept callback as function All this should clear up conflicting authority issues on online events NetStatusBoundary handles app mount with the help of NetService. NetService remains react agnostic collection of functions to be used by various components inside the application. Possible improvements would be to have NetStatusBoundary act as runtime manager of online events instead of having components using netservice directly. That would require a lot more refactor though and it is not clear at the moment if it would bring a huge benefit.
acezard
force-pushed
the
refactor--use-only-one-source-of-online-events
branch
from
c44d2c5 to
296bcb0
Compare
Ldoppea
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this should clear up conflicting authority issues on online events
NetStatusBoundary handles app mount with the help of NetService.
NetService remains react agnostic collection of functions to be used
by various components inside the application.
Possible improvements would be to have NetStatusBoundary act as runtime
manager of online events instead of having components using netservice
directly. That would require a lot more refactor though and it is not
clear at the moment if it would bring a huge benefit.