Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Convert JSInterception console.warn to log #1042

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

Crash--
Copy link
Contributor

@Crash-- Crash-- commented Nov 29, 2023

We still want to send the console.warn() from the flagship app to sentry, but we don't want to send the console.warn coming from the WebApp to sentry. It makes too much noise and since we can't fix them from the flagship app, we don't need to send them. They should be already sent by the wepabb to its own sentry.

Please explain what this PR does here.

Checklist

Before merging this PR, the following things must have been done:

  • Faithful integration of the mockups at all screen sizes
  • Tested on iOS
  • Tested on Android
  • Localized in English and French
  • All changes have test coverage
  • Updated README & CHANGELOG, if necessary

We still want to send the console.warn() from the flagship
app to sentry, but we don't want to send the console.warn
coming from the WebApp to sentry. It makes too much noise
and since we can't fix them from the flagship app, we don't
need to send them. They should be already sent by the wepabb
to its own sentry.
Copy link
Contributor

@acezard acezard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding a comment in the code why we do this (the commit describes it but just to be even more explicit)

@Crash-- Crash-- merged commit 8266114 into master Dec 1, 2023
1 check passed
@Crash-- Crash-- deleted the fix/WarnSentry branch December 1, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants