Multiple bug fixed when deleting manually backup folder #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function in manageBackup should be high level function. Now we have a autonomous and complete initializeLocalBackupConfig to start a backup from the beginning.
getLocalBackupConfig is wrapped in a try / catch block to check efficiently if there is already a local backup config. But we must not add more code in the try block, because in the catch block we reset the local backup config. Everything that must follow a "backup found" case must be outside the try block.
In this case : - user backup his phone : folder A - user trash folder A - user backup his phone : folder B - user restore folder A *backup feature backup to folder B* - user reinstall app *backup feature must backup to folder B* Backup feature will try to find a folder with the same device ID. But folder A and folder B have the same id. Previously, the first folder received by the stack was selected (folder A). But we want to select the most recent one (folder B).
Crash--
approved these changes
Dec 5, 2023
Error message was missing when partial success. Allow front end to display it.
Some network errors coming from cozy-client were not detected by backup feature, so we could not display the good error message to the user. Now we do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an user creates a backup, it creates a backup folder like
/Photos/Sauvegardé depuis mon mobile, and the flagship app saves a reference to this backup folder.In this PR, I mainly handle missing cases, especially when the user trash or trash + empty trash the backup folder.
Some refactoring too.