feat: Handle MAIN_FOLDER_REMOVED error on saveFiles #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doubleface
force-pushed
the
feat/mainFolderRemoved
branch
from
9822b7f to
54b1e25
Compare
Crash--
approved these changes
Nov 24, 2023
When this even occurs, it means that the main destination folder of the konnector has been removed during konnector execution. In this case, we : - Regenerate the files index - create the destination folder according to the manifest - update the trigger with the new message.folder_to_save attribute - retry saveFiles see konnectors/libs#973
doubleface
force-pushed
the
feat/mainFolderRemoved
branch
from
54b1e25 to
48dc40c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this even occurs, it means that the main destination folder of the
konnector has been removed during konnector execution.
In this case, we :
see konnectors/libs#973
Still needs konnectors/libs#973 to be merged and the resulting version of cozy-clisk to be added.
Checklist
Before merging this PR, the following things must have been done: