Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hammerjs #3295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove hammerjs #3295

wants to merge 1 commit into from

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Jan 15, 2025

Remove the hammerjs dep which was used only for one behavior. Not necessary to add two packages which what it implies for this behavior that can easily be managed manually.

To do :

  • test on Chrome
  • test on Firefox
  • test on Safari
  • test on iOS AA
  • test on iOS mobile
  • test on Android AA
  • test on Android mobile

@zatteo zatteo force-pushed the feat/remove-hammerjs branch from 2fbbc5a to 468788d Compare January 16, 2025 10:15
Copy link

bundlemon bot commented Jan 16, 2025

BundleMon

Files updated (3)
Status Path Size Limits
app/drive.(hash).js
159.97KB (-309B -0.19%) -
vendors/drive.(hash).js
2.32MB (-7.45KB -0.31%) -
public/drive.(hash).js
2.09MB (-7.61KB -0.35%) -
Unchanged files (15)
Status Path Size Limits
public/pdf.worker.entry.(hash).worker.js
345.35KB -
services/qualificationMigration/drive.js
283.33KB -
services/dacc/drive.js
262.91KB -
public/cozy-client-js.js
159.28KB -
intents/drive.(hash).js
86.07KB -
public/drive.(hash).min.css
39.46KB -
onlyOffice/slide.pptx
24.83KB -
app-drive.(hash).min.css
10.69KB -
intents-drive.(hash).min.css
8.44KB -
onlyOffice/text.docx
5.85KB -
onlyOffice/spreadsheet.xlsx
5.02KB -
manifest.webapp
1.92KB -
index.html
598B -
intents/index.html
508B -
manifest.json
185B -

Total files change -15.36KB -0.26%

Groups updated (3)
Status Path Size Limits
app/**
159.97KB (-309B -0.19%) -
vendors/**
2.32MB (-7.45KB -0.31%) -
public/**
2.63MB (-7.61KB -0.28%) -
Unchanged groups (4)
Status Path Size Limits
services/**
546.25KB -
intents/**
86.56KB -
onlyOffice/**
35.7KB -
img/**
5.85KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

// remove event when it's the checkbox or the more button
if (
parentDiv.className.indexOf(styles['fil-content-file-select']) !== -1 ||
parentDiv.className.indexOf(styles['fil-content-file-action']) !== -1
Copy link
Contributor Author

@zatteo zatteo Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition is not necessary anymore. These buttons does not trigger an event at all.

@zatteo zatteo changed the title feat: Remove hammerjs Remove hammerjs Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant