feat: Make mime-types package optional #383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nono
reviewed
Mar 8, 2019
| "qs": "6.6.0" | ||
| }, | ||
| "optionalDependencies": { | ||
| "mime-types": "2.1.20" | ||
| }, |
There was a problem hiding this comment.
As I understand, if we put mime-types in optionalDependencies, yarn&npm will try by default to install it. I don't know if we shouldn't put in peerDependencies.
There was a problem hiding this comment.
peerDependency allows us to define the version of the dependency outside of the lib. It's aimed a not duplicating modules across different libraries. peerDependencies are required dependencies, they will always be present in the final lib
|
Closing in favor of #373 An app can use a webpack alias to an empty file if it does not need mime functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mime-db (on which mime-types rely) is very big (see cozy/cozy-banks#926) and not all apps rely on automatic
file type from extension.
Related : #373
In this PR, mime-types is made optional, if an app wants to
use automatic file type detection from extension, it can
add manually the mime-types package (Drive :) ).