Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(konnectors): Avoid creating multiple konnector folders (SCR-896) #1573

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix(konnectors): Avoid creating multiple konnector folders (SCR-896) #1573

merged 1 commit into from
Jan 15, 2025

Conversation

doubleface
Copy link
Contributor

When the account folder already exist and has konnector reference and
not the konnector folder

@doubleface doubleface force-pushed the feat/doubleKonnectorFolder branch 4 times, most recently from 71f2d94 to b818f54 Compare December 17, 2024 08:18
@doubleface doubleface changed the title feat(konnectors): Avoid creating multiple konnector folders (SCR-896) fix(konnectors): Avoid creating multiple konnector folders (SCR-896) Dec 17, 2024
paultranvan
paultranvan approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@paultranvan paultranvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.
It made me think that it would be nice to have documentation about the konnector's complete data model, i.e. which relations are used between documents, accounts, folder, trigger, etc.
Do we already have something like this?

packages/cozy-client/src/models/konnectorFolder.js Outdated Show resolved Hide resolved
packages/cozy-client/src/models/konnectorFolder.js Outdated Show resolved Hide resolved
fix(konnectors): Avoid creating multiple konnector folders
fff577b 
When the account folder already exist and has konnector reference and
not the konnector folder
@doubleface doubleface force-pushed the feat/doubleKonnectorFolder branch from b818f54 to fff577b Compare December 20, 2024 09:36
@doubleface doubleface merged commit 14ec6c4 into master Jan 15, 2025
3 checks passed
@doubleface doubleface deleted the feat/doubleKonnectorFolder branch January 15, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paultranvan paultranvan paultranvan approved these changes

@Merkur39 Merkur39 Awaiting requested review from Merkur39 Merkur39 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doubleface @paultranvan