Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto launch on mac #601

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Auto launch on mac #601

merged 2 commits into from
Apr 3, 2017

Conversation

nono
Copy link
Member

@nono nono commented Mar 31, 2017

No description provided.

@nono nono requested a review from sebn March 31, 2017 15:49
@codecov-io
Copy link

codecov-io commented Mar 31, 2017

Codecov Report

Merging #601 into master will increase coverage by 0.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   71.29%   72.28%   +0.98%     
==========================================
  Files          23       21       -2     
  Lines        1665     1609      -56     
==========================================
- Hits         1187     1163      -24     
+ Misses        478      446      -32
Impacted Files Coverage Δ
src/local/index.js 92.92% <0%> (-3.44%) ⬇️
src/remote/watcher.js
src/remote/index.js
src/local/watcher.js 90% <0%> (+14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e005461...cbdd18e. Read the comment docs.

@sebn
Copy link
Contributor

sebn commented Apr 3, 2017

Maybe add some comment regarding the status of Teamwork/node-auto-launch#28?
Or Teamwork/node-auto-launch#38 (which was supposed to fix the former)?

@sebn
Copy link
Contributor

sebn commented Apr 3, 2017

@nono or do you want to merge this quickly?

@nono
Copy link
Member Author

nono commented Apr 3, 2017

AFAICT, #38 is not suitable for electron apps, and #28 is still open. So, we can merge as is.

@sebn sebn merged commit 1ca3a44 into cozy-labs:master Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants