Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icETH and ACX token #6

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Add icETH and ACX token #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa34ae0
Add icETH and ACX token
fleupold Dec 7, 2022
4e622bc
bump version
fleupold Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/public/CowSwap.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"version": {
"major": 0,
"minor": 0,
"patch": 1
"patch": 2
},
"logoURI": "https://gnosis.mypinata.cloud/ipfs/Qme9B6jRpGtZsRFcPjHvA5T4ugFuL4c3SzWfxyMPa59AMo",
"keywords": [
Expand Down Expand Up @@ -436,6 +436,22 @@
"decimals": 18,
"chainId": 1,
"logoURI": "https://gateway.pinata.cloud/ipfs/QmSxuQpx3UadQY4B2i5AQAaU97JZqkhcm9dCZXXNsNziYR"
},
{
"symbol": "icETH",
"name": "Interest Compounding ETH Index",
"address": "0x7C07F7aBe10CE8e33DC6C5aD68FE033085256A84",
"decimals": 18,
"chainId": 1,
"logoURI": "https://assets.website-files.com/60d237b6ea65be721ff4bbfa/62388a82c46d9a1dfb3dc506_icETH-token-logo.png"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: All of our logos are uploaded to IPFS (which ensures availability even if they are no longer accessible at the specified URL). I think we should do the same for this here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too (mentioned in the PR description) however it's not true that all other token images are hosted on IPFS (a lot of them are hosted via the 1Inch list). We could also host them in this repo.

I can take the time to convert those and also write a proper readme if we agree on a process.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry - I just looked at the ones immediately above the added tokens.

},
{
"symbol": "ACX",
"name": "Across Protocol Token",
"address": "0x44108f0223A3C3028F5Fe7AEC7f9bb2E66beF82F",
"decimals": 18,
"chainId": 1,
"logoURI": "https://raw.githubusercontent.com/balancer-labs/assets/master/assets/0x44108f0223a3c3028f5fe7aec7f9bb2e66bef82f.png"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem.

}
]
}
}