Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up cleanup #305

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Follow up cleanup #305

merged 3 commits into from
Nov 13, 2023

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Nov 8, 2023

Delete TEMP files, ignore them too

Screenshot 2023-11-08 at 14 20 05

Also adds some TODO to address the issue with uniqueness

@anxolin anxolin mentioned this pull request Nov 8, 2023
Merged
@anxolin anxolin requested review from a team and alfetopito November 9, 2023 10:36
alfetopito
alfetopito approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😌

@anxolin anxolin merged commit 836b604 into main Nov 13, 2023
5 checks passed
@anxolin anxolin deleted the follow-up-cleanup branch November 13, 2023 09:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anxolin @alfetopito