Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lowercase token addresses directories #287

Merged
merged 6 commits into from
Oct 16, 2023
Merged

fix: lowercase token addresses directories #287

merged 6 commits into from
Oct 16, 2023

Conversation

shoom3301
Copy link
Contributor

@shoom3301 shoom3301 commented Oct 13, 2023 •
edited
Loading

  1. Lowercased existing directories (commit)
  2. Lowercased logoURI in info.json files (commit)
  3. Lowercased logoURI in CowSwap.json (commit)
  4. Added token address lowercasing in executeAction.yml (commit)

@shoom3301 shoom3301 requested a review from a team October 16, 2023 08:08
@shoom3301 shoom3301 marked this pull request as ready for review October 16, 2023 08:08
alfetopito
alfetopito requested changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I should have done this in the first place 🙈

BTW, not all token image urls can be lower cased. See the comments.

Also, this should be updated too

token-lists/src/scripts/workflow_helper.py

Line 69 in d4de444

file_path = f'src/public/images/{data["chainId"]}/{data["address"]}/info.json'

.github/workflows/executeAction.yml
Comment on lines +31 to +35
# https://stackoverflow.com/questions/62627931/github-actions-expression-functions-string-manipulation
- name: Set address lowercase
id: setAddressLowerCase
run: INPUT=${{ fromJSON(inputs.issueInfo).address }} echo "::set-output name=addressLowerCase::${INPUT,,}"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great you added also the stackoverflow ref!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@shoom3301
Copy link
Contributor Author

Thanks for this, I should have done this in the first place 🙈

BTW, not all token image urls can be lower cased. See the comments.

Also, this should be updated too

token-lists/src/scripts/workflow_helper.py

Line 69 in d4de444

file_path = f'src/public/images/{data["chainId"]}/{data["address"]}/info.json'

@alfetopito thanks! fixed it as well

@shoom3301
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 16, 2023
@github-actions
@shoom3301 has signed the CLA from Pull Request #287
2310696
@shoom3301 shoom3301 merged commit f069ba8 into main Oct 16, 2023
@shoom3301 shoom3301 deleted the fix/lowercase-address branch October 16, 2023 15:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin left review comments

@alfetopito alfetopito alfetopito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoom3301 @alfetopito @anxolin