Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: validate token name max length #237

Merged
merged 11 commits into from
Aug 2, 2023

Conversation

alfetopito
Copy link
Collaborator

@alfetopito alfetopito commented Aug 1, 2023

Summary

Added a validation step to the build to validate the token list against the token list schema

Testing

All checks should pass

@socket-security
Copy link

socket-security bot commented Aug 1, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
ajv-cli 5.0.0 eval, filesystem +15 2.91 MB esp
ajv-formats 2.1.1 None +6 1.62 MB esp
ajv 8.12.0 eval +5 1.57 MB esp
@uniswap/token-lists 1.0.0-beta.33 environment +0 113 kB lynnshaoyu

@alfetopito alfetopito force-pushed the validate-token-name-max-length branch from c3557b5 to 1f49287 Compare August 1, 2023 12:45
@alfetopito alfetopito marked this pull request as ready for review August 2, 2023 14:49
@alfetopito
Copy link
Collaborator Author

I'll merge to test using the form with invalid token length and test the whole flow

@alfetopito alfetopito requested a review from a team August 2, 2023 14:51
@alfetopito alfetopito merged commit 36df5cd into main Aug 2, 2023
@alfetopito alfetopito deleted the validate-token-name-max-length branch August 2, 2023 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant