Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logoURI with github hosted version where possible #213

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

fleupold
Copy link
Contributor

This PR changes all the URL of logos which we have stored in this repository with the corresponding rar github perma links (in case one of these non github hosted sources goes down)

Wrote a little script the checks all links are working

cat CowSwap.json | jq '.tokens[] | .logoURI' | sed 's/"//g' | while read -r logoURI; do
    echo "Checking $logoURI"
    curl -s -w "%{http_code}" "$logoURI"
done

Which actually showed that the Minerva Wallet SuperToken and FRACTION logos are no longer available (but also not yet hosted by us)

@fleupold fleupold requested a review from alfetopito June 18, 2023 19:17
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Working great -> https://tokenlists.org/token-list?url=https://raw.githubusercontent.com/cowprotocol/token-lists/1f252499ab2a66537352651f0877eafd1ab8ee18/src/public/CowSwap.json

The only missing image I saw is for FRACTION.

Minerva does load:
image
from their endpoint

"logoURI": "https://minerva.digital/i/MIVA-Token.svg"

Also noticed that the list logo itself is no longer available:

"logoURI": "https://ipfs.cow.fi/ipfs/Qme9B6jRpGtZsRFcPjHvA5T4ugFuL4c3SzWfxyMPa59AMo",

Anyway, would the script you created be useful again?
If that's the case, might be worth saving it under src/scripts

@fleupold fleupold merged commit ea320c2 into develop Jun 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
@alfetopito alfetopito deleted the replace_links_with_selfhosted branch June 29, 2023 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants