Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update License Links #498

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Update License Links #498

merged 2 commits into from
Sep 2, 2022

Conversation

nlordell
Copy link
Contributor

@nlordell nlordell commented Sep 1, 2022

I noticed while perusing that the soft-links to the LICENSE-* files were bad. This is likely a left-over artifact from when we moved all our crates to crates/*.

This PR does serveral things:

  • Fixes the existing LICENSE-* soft-links.
  • Adds license information to new crates that were missing them
  • Fixes up the authors tag to correctly reflect the "CoW-team-only" crates (i.e. crates that were created after the spin-off)
  • mv number_conversions number-conversions just so it is consistent with our other crate package names and the Rust naming standard (I was messing with file paths anyway). Note that this doesn't cause any code changes because a crate package named foo-bar is linked as a crate library foo_bar.

Test Plan

% for d in crates/*; do ls $d/LICENSE-* 1>/dev/null; done
% for f in $(fd 'LICENSE-*'); do cat $f 1>/dev/null; done

Notice no errors!

Before this PR, you would get the following errors in ZSH:

% git checkout main
% for d in crates/*; do ls $d/LICENSE-* 1>/dev/null; done
zsh: no matches found: crates/alerter/LICENSE-*
zsh: no matches found: crates/autopilot/LICENSE-*
zsh: no matches found: crates/database/LICENSE-*
zsh: no matches found: crates/driver/LICENSE-*
zsh: no matches found: crates/global-metrics/LICENSE-*
zsh: no matches found: crates/number_conversions/LICENSE-*
zsh: no matches found: crates/testlib/LICENSE-*
% for f in $(fd 'LICENSE-*'); do cat $f 1>/dev/null; done
cat: ./crates/contracts/LICENSE-APACHE: No such file or directory
cat: ./crates/contracts/LICENSE-MIT: No such file or directory
cat: ./crates/e2e/LICENSE-APACHE: No such file or directory
cat: ./crates/e2e/LICENSE-MIT: No such file or directory
cat: ./crates/model/LICENSE-APACHE: No such file or directory
cat: ./crates/model/LICENSE-MIT: No such file or directory
cat: ./crates/orderbook/LICENSE-GPL: No such file or directory
cat: ./crates/shared/LICENSE-APACHE: No such file or directory
cat: ./crates/shared/LICENSE-MIT: No such file or directory
cat: ./crates/solver/LICENSE-GPL: No such file or directory

@nlordell nlordell requested a review from a team as a code owner September 1, 2022 17:14
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me but I would trust you on this one. 🙈

@nlordell nlordell merged commit 02c2c66 into main Sep 2, 2022
@nlordell nlordell deleted the fix-license-links branch September 2, 2022 08:44
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants