Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
arguments::display_*
to do a little more than just display the arguments. When implementing additional arguments flags for other PRs, I found the pattern required to use those helper methods quite tedious and error-prone (I would forget thewriteln
at the end, usewriteln
instead ofwrite
for the name, place another field between thedisplay_*
andwriteln!(f)
to name a few):Since the
arguments::display_*
methods are only ever used for fields, I thought it made sense to specialize them so its a bit more ergonomic to use:Test Plan
Run the crates and see the formatted arguments still work (not included here as it would make the PR description too long).
Some highlights:
Before:
After: