Log when orders are filtered because of missing allowance/balance #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
reviewed
Aug 30, 2022
vkgnosis
approved these changes
Aug 30, 2022
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it much simpler to debug issues teams are having with not getting their order matched.
Ideally we would expose this information on the order endpoint so that the explorer can tell the user directly what's wrong (and potentially even persist the last seen state so that we can identify which expired orders weren't actually fillable) but looking at the current design, this is a much more involved task.
Test Plan
Run orderbook, autopilot and UI locally. Place order, afterwards move funds and observe: