Add auction database functions to orderbook and autopilot #436
Conversation
| } | ||
|
|
||
| impl Postgres { | ||
| pub async fn solvable_orders(&self, min_valid_to: u32) -> Result<SolvableOrders> { |
There was a problem hiding this comment.
This function is copied from the orderbook crate where it can be removed when the autopilot takes over.
| fn full_order_into_model_order(order: database::orders::FullOrder) -> Result<Order> { | ||
| let status = OrderStatus::Open; |
There was a problem hiding this comment.
Copied from the orderbook crate. I'm planning on eventually changing the Order type that is used in the autopilot and in the auction endpoint to contain only information relevant to solvers so that we don't need this anymore.
|
|
||
| let data = serde_json::to_value(&auction)?; | ||
| let mut ex = self.0.begin().await?; | ||
| database::auction::delete_all_auctions(&mut ex).await?; |
There was a problem hiding this comment.
It's okay to delete all the auctions here because they will end up in the settlement competition table eventually, right?
There was a problem hiding this comment.
I also found the fact that we can delete all auctions surprising.
I know that we store he settlement competition information in the database, and it includes order UIDs that were included in the auction - but maybe it does make sense to also include this additional data (because things like available balance, executed amounts, etc. get lost).
There was a problem hiding this comment.
At the moment this table just facilitates communicating the auction from the autopilot to the orderbook and giving a persistently increasing id to the autopilot. The settlement competition table still exists and the way it works isn't changed in this PR. That means there is no reason to persist these auctions.
Eventually I could see us combining the tables in some way but I'm not sure about the details yet.
I don't see this question unless you mean Martin's question. |
Codecov Report
@@ Coverage Diff @@
## main #436 +/- ##
==========================================
- Coverage 63.59% 63.40% -0.20%
==========================================
Files 228 230 +2
Lines 44586 44703 +117
==========================================
- Hits 28355 28343 -12
- Misses 16231 16360 +129 |
They will be used soon in another PR that makes the autopilot store auctions in the database and the orderbook read them from the database.
Test Plan
CI, actual db logic is already tested in database crate